-
Notifications
You must be signed in to change notification settings - Fork 3
Tag the latest update #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
layouts/updates/list.html
Outdated
{{ range $index, $_ := .Pages.ByDate.Reverse }} | ||
<tr> | ||
<td><a href='{{ .RelPermalink }}' title="See a summary of the changes in this release">{{ .Title }}</a></td> | ||
<td><a href='{{ .RelPermalink }}' title="See a summary of the changes in this release">{{ .Title }}</a>{{ if (eq $index 0) }}(Latest){{ end }}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a space missing between the update name and (Latest).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it could be nice to have the text (Latest) in a different colour to highlight it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d3101fb, I think colouring it might be a bit tacky.
layouts/updates/list.html
Outdated
{{ range $index, $_ := .Pages.ByDate.Reverse }} | ||
<tr> | ||
<td><a href='{{ .RelPermalink }}' title="See a summary of the changes in this release">{{ .Title }}</a></td> | ||
<td><a href='{{ .RelPermalink }}' title="See a summary of the changes in this release">{{ .Title }}</a>{{ if (eq $index 0) }}(Latest){{ end }}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it could be nice to have the text (Latest) in a different colour to highlight it.
please re-review, as I've fixed the issues
Why is this necessary? The latest release will always be the top-most. This just makes the page unnecessarily noisy? |
Since the release dates are clearly visible, I don't feel this is necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the list is ordered by date, and version numbers are clearly visible, I don't think this is necessary
We need to think about the UX here, having some bold text pointing where people should look is very helpful. Especially because there's no obvious order for the update name on the far left column, some may think that 'Kickstart 2018' is the latest. |
This is a perfectly reasonable point. However it's non-obvious to me that this implementation is the best. Personally I think it adds visual clutter which decreases the UX. We should also consider the technical overhead of doing this. No change that adds things is free of maintenance or cognitive load when reading the source. All features are forms of complexity. We should be judging whether that complexity is worth the benefits of the feature.
I agree with that, though I'd generalise it that visual markers of some form can help point things out.
I disagree. Everyone in the target audience knows what Kickstart was and when it was. That the rest are named after dates means that it's pretty obvious what the ordering is. |
I think the ideal implementation would add a class to the row of the current update and then that would be styled. This nicely separates content from styling, yet still allows for any of the visual implementations which have been proposed so far. |
- Use a class identifier for the row of the table
…nto point-at-latest-update
Tests are failing due to an unrelated link check |
Please don't request changes unless you're certain that changes need to be made
I'm not sure if this was done before this PR was made, but the release date is in the list, so it's obvious which way round it is. The names are also somewhat-related to when they were released (I don't like this, it's on my list!). But I think adding additional noise isnt the answer. An idea I was toying with on something external, was having a specific entry outside the table, for the latest, and further down, having a table of all releases. Much like the buttons we have at the bottom of the update page, we specifically move the latest release buttons out of the table flow, making it incredibly obvious, without adding noise to the table. Most versioned software downloads employ a similar approach. |
Add a
(Latest)
to the latest update to improve readability